Add a JsError::from_rust constructor to create native errors from Rust#3921
Merged
jedel1043 merged 2 commits intoboa-dev:mainfrom Aug 3, 2024
Merged
Add a JsError::from_rust constructor to create native errors from Rust#3921jedel1043 merged 2 commits intoboa-dev:mainfrom
jedel1043 merged 2 commits intoboa-dev:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3921 +/- ##
==========================================
+ Coverage 47.24% 51.56% +4.32%
==========================================
Files 476 468 -8
Lines 46892 44965 -1927
==========================================
+ Hits 22154 23188 +1034
+ Misses 24738 21777 -2961 ☔ View full report in Codecov by Sentry. |
Member
|
I like the addition. What do you think about the name |
Contributor
Author
|
@raskad I made the change, PTAL. |
raskad
approved these changes
Aug 2, 2024
jedel1043
approved these changes
Aug 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.